modules: hal_nordic: nrfs: Optimize communication #81455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
hubertmis,
krish2718 and
sachinthegreen
kl-cruz
previously approved these changes
Nov 26, 2024
nordic-krch
force-pushed
the
nrfs_opt
branch
from
4600378 to
ebd6ca9
Compare
Contributor
Author
|
@hubertmis @anangl take a look? Without this nrfs cannot be called from workq context (and this context is used by runtime PM). |
anangl
reviewed
Dec 10, 2024
Member
There was a problem hiding this comment.
Shouldn't && nrfs_backend_connected() be added here?
Member
|
This change seems to be changing the properties of the |
nordic-krch
force-pushed
the
nrfs_opt
branch
from
ebd6ca9 to
a4c8860
Compare
nordic-segl
approved these changes
Dec 10, 2024
nika-nordic
approved these changes
Dec 10, 2024
Contributor
nika-nordic
left a comment
nika-nordic
left a comment
There was a problem hiding this comment.
lack of this PR functionally breaks all drivers that utilize pm_device_runtime_put_async from ISR context (for example SPIM)
masz-nordic
approved these changes
Dec 13, 2024
It is not needed to use always the system work queue to send a message over IPC. In thread context IPC service can be called directly. It speeds up the communication and allows to use nrfs from the system work queue. Legacy approach could easily lead to the deadlock if user would call nrfs from work queue and pend on semaphore until response is received. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
nrfs_opt
branch
from
a4c8860 to
8ad171f
Compare
anangl
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed to use always the system work queue to send a message over IPC. In thread context IPC service can be called directly. It speeds up the communication and allows to use nrfs from the system work queue. Legacy approach could easily lead to the deadlock if user would call nrfs from work queue and pend on semaphore until response is received.